1
Vote

Pull request review crashes Internet Explorer while "loading diff"

description

We have a pull request for the Entity Framework (http://entityframework.codeplex.com/SourceControl/network/forks/UnaiZorrilla/ef/contribution/3691#!/tab/changes), but whenever I try to review it the page gets to "loading diff" on the last few changes and then causes the page to hang (the page is not responding) in Internet Explorer. This makes it impossible to provide feedback on the pull request.

comments

ajcvickers wrote Nov 29, 2012 at 4:42 PM

Note that it appears to work with Chrome.

ajcvickers wrote Nov 29, 2012 at 4:47 PM

Actually, it doesn't really work in Chrome either. It gets past "loading diff" but then the page becomes unusable because it is so slow to respond.

TomCornelius wrote Nov 29, 2012 at 6:23 PM

Thanks - unfortunately this changeset includes a new file that is over 16000 lines long (Resources.cs). Such a large diff definitely causes performance loading issues on that particular page. We're discussing ways to avoid this but for now we believe this scenario is pretty uncommon. Sorry that it affects your experience in this particular case.

A workaround for you could be to click on the 'View full diff' links at the top of the changeset. You should be able to provide your comments from this view as well.

ajcvickers wrote Nov 29, 2012 at 11:27 PM

Thanks for the response Tom. Using "View full diff" worked for me, but please keep in mind that this file is the string resources file for EF and is changed quite often so this could become quite a problem for us. Hopefully it can be fixed given what we heard from Mark when deciding to use CodePlex for hosting the Entity Framework.

Thanks,
Arthur

TomCornelius wrote Nov 30, 2012 at 4:57 PM

That's okay if it changes a lot, as long as all 16000 lines of it doesn't change. :) Actually I'm not sure what the threshold is but even if you had 1000 lines of changes, it should still be okay.

Sign in to add a comment or to set email notifications